Building PK's Concurrently for Partitions #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,14 +135,13 @@ INNER JOIN | |||
| INNER JOIN pg_catalog.pg_namespace AS foreign_table_namespace | |||
| ON | |||
| foreign_table_c.relnamespace = foreign_table_namespace.oid | |||
| INNER JOIN | |||
There was a problem hiding this comment.
This join isn't used for anything
bplunkett-stripe
force-pushed
the
bplunkett/unique-constraint-support
branch
from
19834a9 to
2b8fa27
Compare
bplunkett-stripe
force-pushed
the
bplunkett/unique-constraint-support
branch
from
2b8fa27 to
fba4fe3
Compare
bplunkett-stripe
force-pushed
the
bplunkett/unique-constraint-support
branch
from
fba4fe3 to
b1cdda9
Compare
alexaub-stripe
approved these changes
Aug 31, 2023
Comment on lines
+626
to
+627
| id INT NOT NULL, | ||
| foo VARCHAR(255) NOT NULL |
There was a problem hiding this comment.
is this indent for foo correct?
There was a problem hiding this comment.
Looks like the entire file is messed up. It renders okay in my editor...I'm guessing this is using tabs instead of spaces, which happens to align okay in my editor. I'll fix in a subsequent PR
| ) | ||
|
|
||
| const ( | ||
| PkIndexConstraintType IndexConstraintType = "PRIMARY KEY" |
There was a problem hiding this comment.
thought: Should IndexConstraintType and PkIndexConstraintType be public if IsPk is public? Seems like the current pattern so no need to change for this PR.
There was a problem hiding this comment.
We currently use it to generate the constraint definition. This should be useful when we add support for unique constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build PK constraints concurrently for partitions. This will nicely transition into adding unique constraint support and building unique constraints concurrently for partitions.
Motivation
#64
Testing
Tested via acceptance tests