Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Typo Fixes #68

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Readme Typo Fixes #68

merged 2 commits into from
Sep 6, 2023

Conversation

bplunkett-stripe
Copy link
Collaborator

Description

More README typo fixes

Motivation

Improve README

Testing

None

alexaub-stripe
alexaub-stripe previously approved these changes Sep 5, 2023
Copy link
Collaborator

@alexaub-stripe alexaub-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking comments, LGTM!

README.md Outdated
@@ -105,7 +108,7 @@ if err != nil {
```

## 2. Applying plan
We leave plan application up to the user. For example, Users might want to take out a session-level advisory lock if they are
We leave plan application up to the user. For example, a user might want to take out a session-level advisory lock if they are
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Using 'a user' here is a bit impersonal. Using second-person "you" language might help here.

@@ -52,7 +55,7 @@ go install github.com/stripe/pg-schema-diff/cmd/pg-schema-diff
## Library
```bash
go get -u github.com/stripe/pg-schema-diff
````
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll be missed, little grave mark

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 😢

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bplunkett-stripe bplunkett-stripe merged commit b9c4c8f into main Sep 6, 2023
5 checks passed
@bplunkett-stripe bplunkett-stripe deleted the bplunkett/readme-update branch September 26, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants