Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max connections for plan cmd #93

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

bplunkett-stripe
Copy link
Collaborator

Description

Now that we fetch schemas in parallel, we should set a maximum number of connections on the connection pool for planning.

Motivation

Follow best practices

Testing

 go run ./cmd/pg-schema-diff apply  --dsn "host=localhost user=postgres password=postgres database=somedb" --schema-dir ~/stripe/temp/examplesql
################################## Review plan ##################################
1. ALTER TABLE "public"."foobar" DROP CONSTRAINT "some_other_constraint";
        -- Statement Timeout: 3s

✔ Yes
############################# Executing statement 1 #############################
ALTER TABLE "public"."foobar" DROP CONSTRAINT "some_other_constraint";
        -- Statement Timeout: 3s

Finished executing statement. Duration: 6.794458ms
################################### Complete ###################################
Schema applied successfully

@bplunkett-stripe bplunkett-stripe added the enhancement New feature or request label Jan 25, 2024
@bplunkett-stripe bplunkett-stripe merged commit 75764a0 into main Jan 25, 2024
6 checks passed
@bplunkett-stripe bplunkett-stripe deleted the bplunkett/max-plan-connections branch January 25, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants