Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--resolver-address is accepted multiple times, but causes an error at runtime #212

Open
gautamg795 opened this issue Feb 1, 2024 · 0 comments

Comments

@gautamg795
Copy link

The docs suggest that the --resolver-address flag can be provided multiple times, e.g.

   --resolver-address ADDRESS                  Make DNS requests to ADDRESS (IP:port).  Repeatable.

However, trying to start smokescreen with multiple resolvers fails:

{"level":"fatal","msg":"Could not create configuration: only one resolver address allowed, 2 provided","time":"2024-02-01T23:20:40.712120055Z"}

It appears support for multiple resolvers hasn't been implemented in the code yet:

// TODO: support round-robin between multiple addresses

Perhaps the docs should be updated first to reflect this, as I suspect the feature itself is nontrivial to implement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant