From 605614aa4b0bdc358d4e21166699fae01a24cb53 Mon Sep 17 00:00:00 2001 From: Yuki Date: Wed, 16 Oct 2024 10:11:08 -0700 Subject: [PATCH] Fix --- .../EmbeddedPaymentElement+Internal.swift | 30 ------------------- .../EmbeddedPaymentElementTest.swift | 2 +- 2 files changed, 1 insertion(+), 31 deletions(-) diff --git a/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Embedded/EmbeddedPaymentElement+Internal.swift b/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Embedded/EmbeddedPaymentElement+Internal.swift index 4e15406adc3..56c33aedc01 100644 --- a/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Embedded/EmbeddedPaymentElement+Internal.swift +++ b/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Embedded/EmbeddedPaymentElement+Internal.swift @@ -51,36 +51,6 @@ extension EmbeddedPaymentElement { delegate: delegate ) } - - struct _UpdateResult { - let loadResult: PaymentSheetLoader.LoadResult - let view: EmbeddedPaymentMethodsView - } - - nonisolated static func update( - configuration: Configuration, - intentConfiguration: IntentConfiguration - ) async throws -> _UpdateResult { - // TODO: Change dummy analytics helper - let dummyAnalyticsHelper = PaymentSheetAnalyticsHelper(isCustom: false, configuration: .init()) - let loadResult = try await PaymentSheetLoader.load( - mode: .deferredIntent(intentConfiguration), - configuration: configuration, - analyticsHelper: dummyAnalyticsHelper, - integrationShape: .embedded - ) - // 1. Update our variables. Re-initialize embedded view to update the UI to match the newly loaded data. - let embeddedPaymentMethodsView = await Self.makeView( - configuration: configuration, - loadResult: loadResult - // TODO: https://jira.corp.stripe.com/browse/MOBILESDK-2583 Restore previous payment option - ) - - // 2. Pre-load image into cache - // Hack: Accessing paymentOption has the side-effect of ensuring its `image` property is loaded (from the internet instead of disk) before we call the completion handler. - _ = await embeddedPaymentMethodsView.displayData - return .init(loadResult: loadResult, view: embeddedPaymentMethodsView) - } } // MARK: - EmbeddedPaymentMethodsViewDelegate diff --git a/StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/EmbeddedPaymentElementTest.swift b/StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/EmbeddedPaymentElementTest.swift index de857783a01..3a9113f56fd 100644 --- a/StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/EmbeddedPaymentElementTest.swift +++ b/StripePaymentSheet/StripePaymentSheetTests/PaymentSheet/EmbeddedPaymentElementTest.swift @@ -122,7 +122,7 @@ extension EmbeddedPaymentElementTest: EmbeddedPaymentElementDelegate { func embeddedPaymentElementDidUpdatePaymentOption(embeddedPaymentElement: StripePaymentSheet.EmbeddedPaymentElement) {} } -extension EmbeddedPaymentElement.UpdateResult: @retroactive Equatable { +extension EmbeddedPaymentElement.UpdateResult: Equatable { public static func == (lhs: StripePaymentSheet.EmbeddedPaymentElement.UpdateResult, rhs: StripePaymentSheet.EmbeddedPaymentElement.UpdateResult) -> Bool { switch (lhs, rhs) { case (.succeeded, .succeeded): return true