Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanModal definitions conflict #1818

Closed
james-ff opened this issue Jun 11, 2021 · 2 comments
Closed

PanModal definitions conflict #1818

james-ff opened this issue Jun 11, 2021 · 2 comments
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@james-ff
Copy link

Summary

When installing via Cocoapods the latest versions of Stripe's iOS SDK, and PanModal, there is a definition clash

Code to reproduce

pod "Stripe", "21.6.0"
pod "PanModal", "1.2.7"

Have tried to replicate with a fresh project, but can't seem to reproduce, although in our main project it is very reproducible.

iOS version

Minimum set to 13

Installation method

Cocoapods

SDK version

21.6.0

Other information

Screenshot 2021-06-11 at 14 56 01
Screenshot 2021-06-11 at 14 56 14
@davidme-stripe
Copy link
Contributor

Hello! This was an oversight on our part, very sorry about that. We'll namespace our internal PanModal and release a new version soon.

@davidme-stripe davidme-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Jun 11, 2021
@davidme-stripe
Copy link
Contributor

We fixed this in version 21.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@james-ff @davidme-stripe