Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overridden brandImage(for:) is not called in subclass #1827

Closed
mahavi opened this issue Jun 29, 2021 · 2 comments
Closed

Overridden brandImage(for:) is not called in subclass #1827

mahavi opened this issue Jun 29, 2021 · 2 comments
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@mahavi
Copy link

mahavi commented Jun 29, 2021

Summary

Overridden method open class func brandImage(for cardBrand: STPCardBrand) -> UIImage? is not called in subclass.

Code to reproduce

import Stripe
import UIKit

final class PaymentCardTextField: STPPaymentCardTextField {
    override class func brandImage(for cardBrand: STPCardBrand) -> UIImage? {
        nil
    }
}

iOS version

13.x

Installation method

SPM

SDK version

21.5.1

Other information

I guess, the issue is with the incorrect method brandImage(for:) call inside STPPaymentCardTextField - should be Self.brandImage(for: ) instead of STPPaymentCardTextField.brandImage(for:).

@yuki-stripe
Copy link
Collaborator

Thanks for raising this @mahavi, we'll get it into the next release

@yuki-stripe yuki-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Jun 30, 2021
@davidme-stripe
Copy link
Contributor

We fixed this in version 21.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

No branches or pull requests

3 participants