Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: TS def for confirmPayment confirmParams is incomplete #496

Closed
misl-smlz opened this issue Sep 6, 2023 · 2 comments
Closed

[BUG]: TS def for confirmPayment confirmParams is incomplete #496

misl-smlz opened this issue Sep 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@misl-smlz
Copy link

What happened?

stripe.confirmPayment(options) described in https://stripe.com/docs/js/payment_intents/confirm_payment does have a payment_method in its confirmParams.
However, the paymentIntents.ConfirmPaymentData definition does not include the payment_method param. This seems like a bug in the definition.

Environment

Chrome 116.0.5845.141 under Windows 10

Reproduction

No response
@misl-smlz misl-smlz added the bug Something isn't working label Sep 6, 2023
@misl-smlz misl-smlz mentioned this issue Sep 6, 2023
Closed
@brendanm-stripe brendanm-stripe mentioned this issue Sep 14, 2023
Merged
@brendanm-stripe
Copy link
Contributor

Thanks for reporting! I added the param and some tests to validate the new types to the above, will have a teammate review.

@brendanm-stripe
Copy link
Contributor

Merged, and should be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add payment_method type misl-smlz/stripe-js
2 participants
@brendanm-stripe @misl-smlz