Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable unused sessions #374

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

xandervedder
Copy link
Collaborator

fixes the following:

  method: 'POST',
  url: '/api/auth/github?code=d7a197043c3c1a1c3abd',
  route: '/api/auth/github',
  headers: {
    'accept-encoding': 'gzip, deflate',
    'content-length': '0',
    'sec-fetch-site': 'same-origin',
    'sec-fetch-mode': 'cors',
    'sec-fetch-dest': 'empty',
    referer: 'http://localhost:4200/auth/github/callback?code=d7a197043c3c1a1c3abd',
    connection: 'close',
    dnt: '1',
    origin: 'http://localhost:4200',
    'accept-language': 'en-US,en;q=0.5',
    accept: 'application/json, text/plain, */*',
    'user-agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0',
    host: 'localhost:4200'
  },
  body: {},
  query: { code: 'd7a197043c3c1a1c3abd' },
  params: {},
  reqId: 'c2b1af0324ed4eb9950d4f8b1e2c4852',
  time: 2023-05-16T13:33:35.027Z,
  duration: 545,
  error: {
    name: 'Error',
    message: 'Login sessions require session support. Did you forget to use `express-session` middleware?',
    status: 500,
    errors: [],
    stack: 'Error: Login sessions require session support. Did you forget to use `express-session` middleware?\n' +
      '    at SessionManager.logIn (/home/milkshake/Projects/stryker-dashboard/packages/website-backend/node_modules/passport/lib/sessionmanager.js:21:33)\n' +
      '    at IncomingMessage.req.login.req.logIn (/home/milkshake/Projects/stryker-dashboard/packages/website-backend/node_modules/passport/lib/http/request.js:39:26)\n' +
      '    at Strategy.strategy.success (/home/milkshake/Projects/stryker-dashboard/packages/website-backend/node_modules/passport/lib/middleware/authenticate.js:256:13)\n' +
      '    at verified (/home/milkshake/Projects/stryker-dashboard/packages/website-backend/node_modules/passport-oauth2/lib/strategy.js:189:20)\n' +
      '    at Strategy.callback [as _verify] (file:///home/milkshake/Projects/stryker-dashboard/packages/website-backend/src/middleware/securityMiddleware.ts:31:12)\n' +
      '    at /home/milkshake/Projects/stryker-dashboard/packages/website-backend/node_modules/passport-oauth2/lib/strategy.js:205:24\n' +
      '    at /home/milkshake/Projects/stryker-dashboard/packages/website-backend/node_modules/passport-github2/lib/strategy.js:123:14\n' +
      '    at passBackControl (/home/milkshake/Projects/stryker-dashboard/packages/website-backend/node_modules/oauth/lib/oauth2.js:134:9)\n' +
      '    at IncomingMessage.<anonymous> (/home/milkshake/Projects/stryker-dashboard/packages/website-backend/node_modules/oauth/lib/oauth2.js:157:7)\n' +
      '    at IncomingMessage.emit (node:events:524:35)'
  }
}

Might be because of a dependency update that was running yesterday (not sure which one)...

@xandervedder xandervedder temporarily deployed to Acceptance May 16, 2023 13:49 — with GitHub Actions Inactive
@xandervedder xandervedder changed the title fix: unable to log in (locally) fix: unable to log in May 16, 2023
@rouke-broersma rouke-broersma changed the title fix: unable to log in fix: disable unused sessions May 19, 2023
@rouke-broersma rouke-broersma temporarily deployed to Acceptance May 22, 2023 12:02 — with GitHub Actions Inactive
@rouke-broersma rouke-broersma merged commit bd942c6 into master May 22, 2023
@rouke-broersma rouke-broersma deleted the bug/unable-to-authenticate branch May 22, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants