feat(website-frontend): load mutation-test-report-app component directly instead of via cdn #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugo-vrijswijk
force-pushed
the
import-component
branch
from
03722b2 to
c7f7fb4
Compare
hugo-vrijswijk
temporarily deployed
to
Acceptance
GitHub Actions
Inactive
hugo-vrijswijk
force-pushed
the
import-component
branch
2 times, most recently
from
ce30641 to
47e76ac
Compare
…tly instead of via cdn This allows for better bundling, and should lazy-loading/module-splitting be enabled, this won't load the mutation-test-report-app on pages other than the reports page. The event handling is a bit weird, but this is just how Angular is with custom element events, I suppose. Also some minor changes: - Uses nest.js static file serving instead of express middleware. - Adds more strict cache-control headers for static files, this results in __much__ faster loading on subsequent visits. - Adds a robots.txt
hugo-vrijswijk
force-pushed
the
import-component
branch
from
47e76ac to
7f73e1c
Compare
hugo-vrijswijk
temporarily deployed
to
Acceptance
GitHub Actions
Inactive
hugo-vrijswijk
force-pushed
the
import-component
branch
3 times, most recently
from
10ff52b to
93fe7f5
Compare
hugo-vrijswijk
force-pushed
the
import-component
branch
from
93fe7f5 to
7d15795
Compare
hugo-vrijswijk
temporarily deployed
to
Acceptance
GitHub Actions
Inactive
It is. I was actually planning on removing angular from the dashboard after #519 is done, should also reduce the amount of data transferred :). I will look at this in more detail but it seems like a big improvement! |
xandervedder
reviewed
Mar 6, 2024
xandervedder
previously approved these changes
Mar 6, 2024
hugo-vrijswijk
force-pushed
the
import-component
branch
from
c799716 to
49b2b8e
Compare
hugo-vrijswijk
had a problem deploying
to
Acceptance
GitHub Actions
Error
hugo-vrijswijk
force-pushed
the
import-component
branch
from
49b2b8e to
7c75194
Compare
hugo-vrijswijk
had a problem deploying
to
Acceptance
GitHub Actions
Failure
hugo-vrijswijk
temporarily deployed
to
Acceptance
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for better bundling, and should lazy-loading/module-splitting be enabled, this won't load the mutation-test-report-app on pages other than the reports page.
The event handling is a bit weird, but this is just how Angular is with custom element events, I suppose.
Also some minor changes:
setup-nodeworkflow steps with caching to not be dependent on GH Actions node versions and fasternpm ci