Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

karma-jasmine@3.1.0 does not support test filtering #2102

Closed
simondel opened this issue Mar 13, 2020 · 4 comments
Closed

karma-jasmine@3.1.0 does not support test filtering #2102

simondel opened this issue Mar 13, 2020 · 4 comments
Labels
🐛 Bug Something isn't working

Comments

@simondel
Copy link
Member

karma-jasmine@3.1.0 does not support test filtering. This causes Stryker to run more tests than usual and it can impact your mutation score.

More info can be found here: karma-runner/karma-jasmine#256
@simondel simondel added the 🐛 Bug Something isn't working label Mar 13, 2020
@nicojs
Copy link
Member

nicojs commented Apr 23, 2020

@simondel did you ever come around to fix this? I thought you were working on this?

@simondel
Copy link
Member Author

I added detailed info to the karma-jasmine issue describing what’s causing the issue and asking why the code has been changed like that, but I don’t believe any action has been taken so far

@nicojs
Copy link
Member

nicojs commented Apr 23, 2020 •
edited
Loading

Yes there is. The author states that there were no tests failing so he assumed it was fine. He seems to be open for a PR that adds an integration test and puts the code back.

@simondel
Copy link
Member Author

Fixed with karma-jasmine 3.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicojs @simondel