Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] delete (soft and hard) book support #336

Open
Leiasticot opened this issue May 8, 2024 · 5 comments
Open

[FEATURE] delete (soft and hard) book support #336

Leiasticot opened this issue May 8, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@Leiasticot
Copy link

Describe the bug
I didn't have any button to delete a file, and when I delete it from then files still be inside my libraries. Even inside Settings.

To Reproduce
Steps to reproduce the behavior:

  1. .cbz from a webtoon
  2. delete files from the server with rm -r
  3. Inside the library

Expected behavior
When I delete a file inside my server then it is deleted from the library (or at least use a button to not see it always).

Screenshots
image
image
image
image

Desktop (please complete the following information):

  • OS: Docker on debian 12 for server, and client is Windows 11 Chrome
@Leiasticot Leiasticot added the bug Something isn't working label May 8, 2024
@aaronleopold
Copy link
Collaborator

This isn’t necessarily a bug, there is just no delete button or logic to automatically delete books today, but I do think the issue highlights a few areas where we could define better UX in general around these situations.

If a known entity (series, book, etc) is unable to be located on disk during a scan, it’s marked as missing. I recall a few places where books may be marked as missing outside of a scan during API usage, but can’t remember where offhand.

So I guess one question would be is it desirable to update the status of books missing from disk even in some GET requests? Or should it stay as only setting the status when explicitly asked (i.e. during a scan)?

Regardless, delete/trash operations can definitely be added. Initially I’d do it per entity, but then it would be planned accordingly for #258

@Cantello
Copy link

Cantello commented Sep 9, 2024

One related question here: When I rename a book/series after it has been scanned, I have duplicates in my library. Is there any way to remove the duplicates or the missing entities you mentioned above?

@aaronleopold
Copy link
Collaborator

aaronleopold commented Sep 9, 2024

One related question here: When I rename a book/series after it has been scanned, I have duplicates in my library. Is there any way to remove the duplicates or the missing entities you mentioned above?

Yes, there is a Clean library operation in a library's settings which will hard delete them in the database. Eventually, there will be options for soft deletion in some capacity alongside bulk management features (#258)

@Cantello
Copy link

Thanks, I don't know how I missed this when I was looking...

@aaronleopold aaronleopold changed the title [BUG] Missing a delete button ? [FEATURE] delete (soft and hard) book support Sep 11, 2024
@aaronleopold
Copy link
Collaborator

Thanks, I don't know how I missed this when I was looking...

Depending on what version you are trying out, it can be easy to miss. The latest builds are just a long scrollable page, but I've been experimenting with more segmentation in nightly/experimental images and have this housed in a Deletion section in a secondary navigation menu in library settings

@aaronleopold aaronleopold added enhancement New feature or request and removed bug Something isn't working labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants