Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] named contexts for string content #3720

Open
michaelblyons opened this issue May 2, 2023 · 2 comments
Open

[C#] named contexts for string content #3720

michaelblyons opened this issue May 2, 2023 · 2 comments
Labels
C: Syntax T: enhancement Improvement of existing language features

Comments

@michaelblyons
Copy link
Collaborator

michaelblyons commented May 2, 2023

What happened?

This is #3462 for C#:

[M]ake the context(s) pushed for strings with special highlighting into a named context instead of an anonymous one, so extendsed syntaxes can add additional special cases.

See-also: #3659 in case of conflicts Edit: it's merged now. All good.

@deathaxe
Copy link
Collaborator

deathaxe commented May 2, 2023

I guess all syntaxes should be refactored to use named contexts primarily/only ideally with a common context naming scheme.

#3659 intents not to mess with current context naming scheme.

In the long term we should probably go through the syntax and refactor it after the scheme of Python. But honestly, there are probably other syntaxes of higher priority with regards to improving quality of highlighting..

@michaelblyons
Copy link
Collaborator Author

I guess all syntaxes should be refactored to use named contexts primarily/only ideally with a common context naming scheme.

#3659 intents not to mess with current context naming scheme.

Understood. I just wanted anyone who might start on this in the short term to know that they might be creating conflicts.

But honestly, there are probably other syntaxes of higher priority with regards to improving quality of highlighting..

Agreed. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Syntax T: enhancement Improvement of existing language features
Projects
None yet
Development

No branches or pull requests

2 participants