Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff version update #18

Closed
patillacode opened this issue May 2, 2023 · 4 comments
Closed

ruff version update #18

patillacode opened this issue May 2, 2023 · 4 comments

Comments

@patillacode
Copy link

Hi!

Thanks for this project!

A bit of context:

  • I am really interested in some of the recently added features in ruff and they are only available in version 0.0.263

  • I did a bit of research and noticed the version of ruff within LSP-ruff is 0.0.253 and that is why my ruff config was not working properly.

  • I created this PR at charliermarsh/ruff-lsp in case that is the way (please read)

Questions:

Am I approaching this the right way?

Is there a less convoluted way for me to point the executable to my local version of ruff while versions catch up?

I tried to do it via the path setting but I guess I am doing it wrong:

This is one of my last (unsuccessful) tries the LSP-ruff.sublime-settings file:

{
	"initializationOptions": {
        "globalSettings": {
            // same as settings
            "path": ["/usr/local/bin/ruff"],
        },
    },
}

That's it, I'll patiently wait for a response!

@rchl
Copy link
Member

rchl commented May 2, 2023

Updating ruff dependency in ruff-lsp as you did is the way to go. We'll get dependabot notification at some point later and will bump the ruff version through that.

As far as using custom ruff binary, this seems to work for me:

// Settings in here override those in "LSP-ruff/LSP-ruff.sublime-settings"
{
    "initializationOptions": {
        "settings": {
            "path": ["/opt/homebrew/bin/ruff"]
        },
    }
}

Not sure why globalSettings doesn't work.

@rchl
Copy link
Member

rchl commented May 2, 2023

Fixing the issue with not respecting globalSettings in #19

@patillacode
Copy link
Author

Great, thanks!

I could swear I had tried your example settings and it failed, but it is now working!

@rchl
Copy link
Member

rchl commented May 4, 2023

@rchl rchl closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants