Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the Sourcegraph Javascript-typescript-langserver #823

Closed
ghost opened this issue Dec 11, 2019 · 3 comments
Closed

Using the Sourcegraph Javascript-typescript-langserver #823

ghost opened this issue Dec 11, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Dec 11, 2019

Hi,
Just wanted to thank you for the LSP.
I have testing various servers and found that to get the Javascript language server from source graph to recognise javascript files i need to change the settings to.

{ "clients": { "javascript-typescript-langserver": { "enabled": true, "command": ["javascript-typescript-stdio"], "languages": [{ "scopes": ["source.js", "source.jsx"], "syntaxes": ["Packages/Babel/JavaScript (Babel).sublime-syntax", "Packages/JavaScript/JavaScript.sublime-syntax"], "languageId": "javascript" }, { "scopes": ["source.ts", "source.tsx"], "syntaxes": ["Packages/TypeScript-TmLanguage/TypeScript.tmLanguage"], "languageId": "typescript" } ] } }, "diagnostics_gutter_marker": "circle", "log_debug": true, "log_stderr": true, "log_payloads": true, "show_view_status": true }

The difference being that the Syntaxes was originally set to "Javascript" which in my case wasn't enough for LSP to pick *.js files.

@rchl
Copy link
Member

rchl commented Dec 11, 2019

You shouldn't be using JavaScript (Babel) syntax as it's old and unmaintained. Default built-in syntax supports all that stuff already.

@rwols
Copy link
Member

rwols commented Dec 12, 2019

Related: #540

@rwols rwols added this to the Release 1.0.0 milestone Dec 25, 2019
@rwols rwols removed this from the Release 1.0.0 milestone Jan 30, 2020
@rchl
Copy link
Member

rchl commented Mar 26, 2020

I think #540 better describes the problem and a possible solution. Closing this in favor of the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants