Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add between function #287

Merged
merged 2 commits into from
Aug 24, 2022
Merged

feat: add between function #287

merged 2 commits into from
Aug 24, 2022

Conversation

richtia
Copy link
Member

@richtia richtia commented Aug 10, 2022

PR to add between function

jvanstraten
jvanstraten approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll mark this as approved unless someone has more to add to the above discussion about whether we should have this at all.

Not sure what's going on with CI. I guess we merged a protobuf style violation accidentally?

@jacques-n jacques-n merged commit aad6f63 into substrait-io:main Aug 24, 2022
@ianmcook ianmcook mentioned this pull request Sep 2, 2022
Closed
@gatesn gatesn mentioned this pull request Jan 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianhyde julianhyde julianhyde left review comments

@cpcloud cpcloud cpcloud left review comments

@ianmcook ianmcook ianmcook left review comments

@jvanstraten jvanstraten jvanstraten approved these changes

@jacques-n jacques-n jacques-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@richtia @jacques-n @ianmcook @cpcloud @julianhyde @jvanstraten