Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hyperbolic functions #290

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

thisisnic
Copy link
Contributor

This PR adds hyperbolic functions

Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, hm. I guess I didn't catch this in #241, but it should be fp32 -> fp32 and fp64 -> fp64. Unless you're building huge lookup tables (which may or may not be feasible for fp32, not so much for fp64) I see zero reason to have an fp32 -> fp64 variant from a computational perspective, and it goes against #251. Can you change the new functions to fp32 -> fp32? I'll submit a patch to weed out inconsistencies between all the new functions in general (and at some point to codify #251, since there have been no objections) later.

@thisisnic
Copy link
Contributor Author

Uh, hm. I guess I didn't catch this in #241, but it should be fp32 -> fp32 and fp64 -> fp64. Unless you're building huge lookup tables (which may or may not be feasible for fp32, not so much for fp64) I see zero reason to have an fp32 -> fp64 variant from a computational perspective, and it goes against #251. Can you change the new functions to fp32 -> fp32? I'll submit a patch to weed out inconsistencies between all the new functions in general (and at some point to codify #251, since there have been no objections) later.

Good catch, I've updated them in this PR now!

jvanstraten
jvanstraten previously approved these changes Aug 17, 2022
Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now.

@jvanstraten jvanstraten merged commit 4252824 into substrait-io:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants