Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(naming): add missing arg names in functions_arithmetic.yaml #315

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(naming): add missing arg names in functions_arithmetic.yaml #315

merged 1 commit into from
Sep 8, 2022

Conversation

vibhatha
Copy link
Contributor

@vibhatha vibhatha commented Sep 8, 2022

This PR includes a minor fix on the missing argument names in the functions_arithmetic.yaml

@vibhatha vibhatha changed the title fix: Missing arg names added to functions_arithmetic.yaml fix: Add missing arg names in arithmetic functions Sep 8, 2022
@jvanstraten jvanstraten changed the title fix: Add missing arg names in arithmetic functions fix: add missing arg names in arithmetic functions Sep 8, 2022
jvanstraten
jvanstraten approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jvanstraten jvanstraten merged commit d433a06 into substrait-io:main Sep 8, 2022
@jvanstraten jvanstraten changed the title fix: add missing arg names in arithmetic functions fix(naming): add missing arg names in functions_arithmetic.yaml Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanstraten jvanstraten jvanstraten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vibhatha @jvanstraten