feat: add functions for splitting strings #346
Conversation
| - value: "varchar<L2>" | ||
| name: "separator" | ||
| description: A character used for splitting the string. | ||
| return: "List<varchar<L1>>" |
There was a problem hiding this comment.
Wasn't exactly sure how to put the return type.
| - | ||
| name: regex_string_split | ||
| description: >- | ||
| Split a string into a list of strings, based on a regular expression pattern. The |
There was a problem hiding this comment.
I feel like this could use a bit more explanation. I guess the idea is that it works the same as a regular string split, i.e. removing the substrings matched by the regex from the resulting string list. However, I could also imagine someone interpreting it as the regex picking only the split point, such that every character from the original string ends up in one of the returned list elements. Both implementations would be useful, but the one that removes the matched string is more expressive, because you could wrap the regex in a positive lookahead to mimic the other implementation.
There was a problem hiding this comment.
Good point. I updated the description to be more detailed. From what I've seen, the implementation that removes the matched substring is also how a bunch of different SQL dialects do it.
|
|
|
@westonpace could you give this one a look? |
|
Per the sync meeting notes, since there are a significant # of engines that do not support max_split, that would be a second function (e.g. |
PR adds functions for splitting strings and fixed some spacing in the options of other functions.