Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding BibTex entry to cite Substrait #481

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

vibhatha
Copy link
Contributor

@vibhatha vibhatha commented Mar 23, 2023

This PR adds a subsection to Community section in web site.

Closes #480

@github-actions
Copy link

ACTION NEEDED

Substrait follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@vibhatha vibhatha self-assigned this Mar 23, 2023
@vibhatha vibhatha added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 23, 2023
@vibhatha vibhatha changed the title feat: Adding BibTex entry to cite Substrait feat: adding BibTex entry to cite Substrait Mar 23, 2023
@vibhatha vibhatha marked this pull request as ready for review March 23, 2023 05:17
@westonpace
Copy link
Member

I don't know much about bibtex so I'll need to defer to someone more academically minded. This seems reasonable to put on the site.

@mbrobbel
Copy link
Member

mbrobbel commented Mar 23, 2023

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw the conversation on Slack. Can you add the url attribute per @drin 's suggestion?

@westonpace
Copy link
Member

How about using https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files? Nevermind, this is for the site not the repo.

Adding a cittation for the repo as well seems worthwhile

Copy link

@kabicm kabicm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

I would have few suggestions:

  • would avoid hardcoding the full date into the year field, but rather have a month and day fields defined as well.
  • For the date of the repo creation, I see 31. August 2021 (see created_at field here: https://api.github.com/repos/substrait-io/substrait).
  • We can add the accessed date as a note.

For example, something along these lines:

@misc{substrait,
  author = {substrait-io},
  title = {Substrait: Cross-Language Serialization for Relational Algebra},
  year = {2021},
  month=aug,
  day = {31},
  publisher = {GitHub},
  journal = {GitHub repository},
  howpublished = {\url{https://github.com/substrait-io/substrait}},
  note = {Accessed on <add the date here>.}
}

For convenience, we could add a CITATION.cff file, so that github would automatically generate the citation, as proposed here: https://academia.stackexchange.com/questions/14010/how-do-you-cite-a-github-repository.

@vibhatha
Copy link
Contributor Author

Thanks @mbrobbel and @kabicm for the suggestions. I will update the PR.

@vibhatha
Copy link
Contributor Author

@kabicm I think the note field should come from the authors who cite this. It may be less practical to put an accessed date. What do you think?

@kabicm
Copy link

kabicm commented Mar 24, 2023

@vibhatha Thanks for taking a look into the suggestions!

I agree, most users might blindly copy-paste without filling in the access date which might not be as practical.

In that case, we can completely remove the note field and potentially mention in a comment that users can optionally add a field with an access date e.g. as note = {Accessed on <add the date here>.}. It's up to you :)

@vibhatha
Copy link
Contributor Author

I have added a CITATION.cff file, and used the very first release date of Substrait as the data-released. I used their online tool to generate this file.

@kabicm @mbrobbel could you please take a look.

Also @jacques-n could you please also verify if the data entered is accurate and if there are any missing fields?

@vibhatha
Copy link
Contributor Author

@vibhatha Thanks for taking a look into the suggestions!

I agree, most users might blindly copy-paste without filling in the access date which might not be as practical.

In that case, we can completely remove the note field and potentially mention in a comment that users can optionally add a field with an access date e.g. as note = {Accessed on <add the date here>.}. It's up to you :)

Thanks for your suggestion, @kabicm.

In case of authors who just want to copy/paste and wouldn't require the note field will always have to remove that entry. To keep it simple, I think it would be good to remove that field. Authors can always add that field. Hope this clarifies the choice 🙂

@vibhatha vibhatha requested a review from kabicm March 24, 2023 06:54
mbrobbel
mbrobbel previously approved these changes Mar 24, 2023
kabicm
kabicm previously approved these changes Mar 24, 2023
Copy link

@kabicm kabicm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @vibhatha for the work!

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this! Two small requests and then I think we're good.

CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
Copy link
Member

@drin drin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything looks good! I just made 1 suggestion to add the url attribute to the explicit bibtex citation

site/docs/community/index.md Show resolved Hide resolved
drin
drin previously approved these changes Mar 27, 2023
@vibhatha vibhatha dismissed stale reviews from drin and kabicm via 112df47 March 28, 2023 01:48
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems discussion has settled here. Thanks for creating this @vibhatha

@westonpace westonpace merged commit 425e7f8 into substrait-io:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BibTex for citing Substrait
5 participants