-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding BibTex entry to cite Substrait #481
Conversation
ACTION NEEDED Substrait follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
I don't know much about bibtex so I'll need to defer to someone more academically minded. This seems reasonable to put on the site. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw the conversation on Slack. Can you add the url
attribute per @drin 's suggestion?
Adding a cittation for the repo as well seems worthwhile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
I would have few suggestions:
- would avoid hardcoding the full date into the
year
field, but rather have amonth
andday
fields defined as well. - For the date of the repo creation, I see 31. August 2021 (see
created_at
field here: https://api.github.com/repos/substrait-io/substrait). - We can add the accessed date as a note.
For example, something along these lines:
@misc{substrait,
author = {substrait-io},
title = {Substrait: Cross-Language Serialization for Relational Algebra},
year = {2021},
month=aug,
day = {31},
publisher = {GitHub},
journal = {GitHub repository},
howpublished = {\url{https://github.com/substrait-io/substrait}},
note = {Accessed on <add the date here>.}
}
For convenience, we could add a CITATION.cff
file, so that github would automatically generate the citation, as proposed here: https://academia.stackexchange.com/questions/14010/how-do-you-cite-a-github-repository.
@kabicm I think the |
@vibhatha Thanks for taking a look into the suggestions! I agree, most users might blindly copy-paste without filling in the access date which might not be as practical. In that case, we can completely remove the |
I have added a @kabicm @mbrobbel could you please take a look. Also @jacques-n could you please also verify if the data entered is accurate and if there are any missing fields? |
Thanks for your suggestion, @kabicm. In case of authors who just want to copy/paste and wouldn't require the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @vibhatha for the work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this! Two small requests and then I think we're good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything looks good! I just made 1 suggestion to add the url
attribute to the explicit bibtex citation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems discussion has settled here. Thanks for creating this @vibhatha
This PR adds a subsection to
Community
section in web site.Closes #480