feat: add is distinct from function #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JazabC
force-pushed
the
jazabc/feat/is-distinct-from
branch
from
40f98cd
to
8ef5e6a
Compare
bvolpato
approved these changes
May 11, 2024
There was a problem hiding this comment.
Given that the negation form exists (is_not_distinct_from), and that both are valid functions in Postgres and others (https://modern-sql.com/caniuse/is-distinct-from), I think this makes a lot of sense.
JazabC
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
westonpace
approved these changes
May 16, 2024
|
@westonpace sure, on it now. |
vibhatha
approved these changes
May 16, 2024
|
@westonpace Done! |
|
Thanks for the addition @JazabC! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add
is distinct fromfunction