Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "initcap" function #656

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

Blizzara
Copy link
Contributor

Initcap is like "title", but while "title" defines articles
are not to be capitalized, initcap capitalizes also articles.

Initcap is supported by basically all DB systems, including Spark and DataFusion

Initcap is like "title", but while "title" defines articles
 are not to be capitalized, initcap capitalizes also articles.

Initcap is supported by basically all DB systems, including
Spark and DataFusion
EpsilonPrime
EpsilonPrime previously approved these changes Jun 26, 2024
-
name: initcap
description: >-
Converts the input string into init cap case. Capitalize the first character of each word in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

init -> initial

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And cap -> capitalized

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewritten in 94ab9e7, was hard to make it sound good since there's no proper name for the initcap case.

Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EpsilonPrime EpsilonPrime merged commit 95bc6ba into substrait-io:main Jul 3, 2024
13 checks passed
@Blizzara Blizzara deleted the avo/add-initcap branch July 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants