Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arithmetic function "sqrt" and "factorial" with decimal type #674

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

anshuldata
Copy link
Contributor

No description provided.

jacques-n
jacques-n previously approved these changes Aug 1, 2024
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacques-n
Copy link
Contributor

need conflicts resolved before merging.

@jacques-n jacques-n added the awaiting-user-input This issue is waiting on further input from users label Aug 1, 2024
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for rebase.

@jacques-n jacques-n merged commit e4f5b68 into substrait-io:main Aug 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-input This issue is waiting on further input from users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants