Refactor e2e tests #263
Merged
Refactor e2e tests #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nstogner
commented
Oct 6, 2024
•
nstogner
commented
- Add central bash script to run e2e test cases
- Separate e2e tests out into separate cases
- Add python openai client test case
- Fix Remove request body logging #262
samos123
reviewed
Oct 7, 2024
|
End-to-end tests run in parallel (in sequence after unit and integration tests - if those fail, theres not use in tying up resources to run e2e tests): |
|
Should be good to merge if all looks OK |
|
Nice! LGTM. I think I rather run e2e and unit /integration test at the same time so we don't have to wait an additional 4 minutes. I can tackle that in a follow up, lets merge this first. |
samos123
reviewed
Oct 8, 2024
samos123
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.