Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0 #246

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 10, 2024

Bumps github.com/go-sql-driver/mysql from 1.7.1 to 1.8.0.

Release notes

Sourced from github.com/go-sql-driver/mysql's releases.

v1.8.0

What's Changed

Major changes

  • Use SET NAMES charset COLLATE collation. by @​methane in go-sql-driver/mysql#1437

    • Older go-mysql-driver used collation_id in the handshake packet. But it caused collation mismatch in some situation.
    • If you don't specify charset nor collation, go-mysql-driver sends SET NAMES utf8mb4 for new connection. This uses server's default collation for utf8mb4.
    • If you specify charset, go-mysql-driver sends SET NAMES <charset>. This uses the server's default collation for <charset>.
    • If you specify collation and/or charset, go-mysql-driver sends SET NAMES charset COLLATE collation.
  • PathEscape dbname in DSN. by @​methane in go-sql-driver/mysql#1432

    • This is backward incompatible in rare case. Check your DSN.
  • Drop Go 1.13-17 support by @​methane in go-sql-driver/mysql#1420

    • Use Go 1.18+
  • Parse numbers on text protocol too by @​methane in go-sql-driver/mysql#1452

    • When text protocol is used, go-mysql-driver passed bare []byte to database/sql for avoid unnecessary allocation and conversion.
    • If user specified *any to Scan(), database/sql passed the []byte into the target variabe.
    • This confused users because most user doesn't know when text/binary protocol used.
    • go-mysql-driver 1.8 converts integer/float values into int64/double even in text protocol. This doesn't increase allocation compared to []byte and conversion cost is negilible.
  • New options start using the Functional Option Pattern to avoid increasing technical debt in the Config object. Future version may introduce Functional Option for existing options, but not for now.

Other changes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @sue445.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.7.1 to 1.8.0.
- [Release notes](https://github.com/go-sql-driver/mysql/releases)
- [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md)
- [Commits](go-sql-driver/mysql@v1.7.1...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/go-sql-driver/mysql
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 10, 2024
```
panic: interface conversion: interface {} is int64, not []uint8 [recovered]
	panic: interface conversion: interface {} is int64, not []uint8

goroutine 35 [running]:
testing.tRunner.func1.2({0x6e4b00, 0xc00009e120})
	/opt/hostedtoolcache/go/1.22.0/x64/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.22.0/x64/src/testing/testing.go:1634 +0x377
panic({0x6e4b00?, 0xc00009e120?})
	/opt/hostedtoolcache/go/1.22.0/x64/src/runtime/panic.go:770 +0x132
github.com/sue445/plant_erd/adapter/mysql.rowString(...)
	/home/runner/work/plant_erd/plant_erd/adapter/mysql/adapter.go:34
github.com/sue445/plant_erd/adapter/mysql.rowInt(0x6df820?, {0x730ebd?, 0x19?})
	/home/runner/work/plant_erd/plant_erd/adapter/mysql/adapter.go:38 +0xe5
github.com/sue445/plant_erd/adapter/mysql.(*Adapter).getIndexes(0xc0000501f8, {0x730365?, 0x8?})
	/home/runner/work/plant_erd/plant_erd/adapter/mysql/adapter.go:180 +0x337
github.com/sue445/plant_erd/adapter/mysql.(*Adapter).GetTable(0xc0000501f8, {0x730365, 0x8})
	/home/runner/work/plant_erd/plant_erd/adapter/mysql/adapter.go:97 +0x696
github.com/sue445/plant_erd/adapter/mysql.TestAdapter_GetTable.func1.4(0xc00012f1e0)
	/home/runner/work/plant_erd/plant_erd/adapter/mysql/adapter_test.go:236 +0x3e
testing.tRunner(0xc00012f1e0, 0xc000074fc0)
	/opt/hostedtoolcache/go/1.22.0/x64/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 11
	/opt/hostedtoolcache/go/1.22.0/x64/src/testing/testing.go:1742 +0x390
```

c.f. https://github.com/sue445/plant_erd/actions/runs/8224625813/job/22488671695?pr=246
@sue445
Copy link
Owner

sue445 commented Mar 11, 2024

@dependabot merge

@dependabot dependabot bot merged commit ee527d0 into master Mar 11, 2024
37 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/go-sql-driver/mysql-1.8.0 branch March 11, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant