Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remnants/comments of route extensions to request Accept headers should be removed #7

Open
slogsdon opened this issue Feb 9, 2017 · 0 comments

Comments

@slogsdon
Copy link
Member

slogsdon commented Feb 9, 2017

Current dependence on Plug for route param parsing and Erlang's inability to pattern match binaries like param <> ".ext" makes this difficult to handle at compile time without rewriting a good amount of code.

Optimal solution at this point will probably be a plug to be early in the call stack, parsing the last captured param for an extension/MIME-type, setting Accept header, and removing the extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant