musickeyboard only saves default synth

[walterbender]

We should honor the synth set as per:

[walterbender]

DEFAULTVOICE is hardwired throughout the code.

[walterbender]

It works when composing, but the voice is ignored when playing back and when saving.

[walterbender]

It tracks the voice except during save.

[aviral243]

@walterbender What exactly do we need to do here? Please guide.

[walterbender]

Each key can be assigned to a unique instrument. When we save, we don't wrap the set instrument block around the individual notes. (It would be best to group multiple notes using the same instrument, eg, piano do piano re piano mi guitar fa piano sol piano la piano ti --> piano [do re mi] guitar fa piano [la ti]

The relevant code is here:
https://github.com/sugarlabs/musicblocks/blob/master/js/widgets/musickeyboard.js#L1744

[sksum]

@walterbender
I am working on this issue and a design question came up . how would we want to use "set-instrument" for chords with keys that have been assigned different instruments

would something like this work ?

[walterbender]

Looks like an appropriate way to do it. No idea if it works. But we should try to make it work.
(Similar to dropping a drum block into a note along with a pitch.) Probably we need to tweak the way __playnote works in processNotes in logo.js

[pikurasa]

Had no idea that this was implemented. This is very nice.

@walterbender Perhaps we should have the synth in the macros to make this feature more evident.