Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitch to hertz block always shows undefined for the first note. #2264

Closed
vaibhavdaren opened this issue May 15, 2020 · 5 comments
Closed

Pitch to hertz block always shows undefined for the first note. #2264

vaibhavdaren opened this issue May 15, 2020 · 5 comments

Comments

@vaibhavdaren
Copy link
Contributor

vaibhavdaren commented May 15, 2020

Pitch to hertz block always shows undefined for the first note.
The probable reason is race condition.

Screenshot 2020-05-16 at 2 05 58 AM

[1] https://musicblocks.sugarlabs.org/index.html?id=1589542696262980&run=True

@walterbender
Copy link
Member

This is due to the fact that on-every-note-do triggers before the note is played.

I cannot manage to get it to run during the note, only before or after. Maybe we need to have both options available?

@walterbender
Copy link
Member

Before-Every-Note-Do
After-Every-Note-Do

@walterbender
Copy link
Member

@pikurasa what do you think?

@pikurasa
Copy link
Collaborator

@pikurasa what do you think?

Yes, I was thinking the same thing too.

@walterbender
Copy link
Member

We can address this in Music Blocks 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants