Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Pitch (via Temperament) not loaded, not present in palette #2348

Closed
pikurasa opened this issue Jun 12, 2020 · 0 comments
Closed

Custom Pitch (via Temperament) not loaded, not present in palette #2348

pikurasa opened this issue Jun 12, 2020 · 0 comments
Assignees
Labels

Comments

@pikurasa
Copy link
Collaborator

When a user creates a custom temperament, they also get a "custom pitch" block. This block is is loads of fun.

For example, the following block was generated from:

  1. Initiate Temperament Widget
  2. Clear everything
  3. Choose --> Equal, then "5" for value for divisions
  4. Save Custom Temperament

Screenshot at 2020-06-12 08:41:12 custom pitch

However, when you save the MB file and then reopen the file, the block is not present on the pitch palette. It also does not seem to be loaded as code either.

Logs:

skipping octavespace
synthutils.js:1148 guitar already loaded
3
note.js:3 Note created
synthutils.js:1148 snare drum already loaded
2
blocks.js:6605 3: substituting nop flow block for octavespace
blocks.js:5926 
(5) [Array(3), Array(3), Array(3), Array(3), Array(3), pitchNumber: 5]
0: (3) [1, "D(+0)", "4"]
1: (3) [1.148698354997035, "E(+40.00)", "4"]
2: (3) [1.3195079107728942, "G(-20.00)", "4"]
3: (3) [1.515716566510398, "A(+20.00)", "4"]
4: (3) [1.7411011265922482, "C(-40.00)", "5"]
pitchNumber: 5
length: 5
__proto__: Array(0)
blocks.js:5926 
(5) [Array(3), Array(3), Array(3), Array(3), Array(3), pitchNumber: 5]
0: (3) [1, "D(+0)", "4"]
1: (3) [1.148698354997035, "E(+40.00)", "4"]
2: (3) [1.3195079107728942, "G(-20.00)", "4"]
3: (3) [1.515716566510398, "A(+20.00)", "4"]
4: (3) [1.7411011265922482, "C(-40.00)", "5"]
pitchNumber: 5
length: 5
__proto__: Array(0)
turtles.js:82 adding a new turtle start
blocks.js:6825 Finished block loading
ProjectStorage.js:188 Uncaught (in promise) Error: Not enough space to save locally
    at ProjectStorage.set (ProjectStorage.js:188)
    at async ProjectStorage.save (ProjectStorage.js:208)
ProjectStorage.js:188 Uncaught (in promise) Error: Not enough space to save locally
    at ProjectStorage.set (ProjectStorage.js:188)
    at async ProjectStorage.save (ProjectStorage.js:208)
@pikurasa pikurasa added Component-Temperament related to temperament Issue-Bug labels Jun 12, 2020
@sksum sksum self-assigned this Jun 14, 2020
@sksum sksum added WF6-Needs testing Please test and removed WF6-Needs testing Please test labels Jun 15, 2020
@sksum sksum added the WF6-Needs testing Please test label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants