Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperament Widget Enhancements #2351

Closed
pikurasa opened this issue Jun 12, 2020 · 0 comments
Closed

Temperament Widget Enhancements #2351

pikurasa opened this issue Jun 12, 2020 · 0 comments
Labels
Component-Temperament related to temperament Component-Widget relating to a widget Issue-Enhancement WF6-Needs testing Please test

Comments

@pikurasa
Copy link
Collaborator

  1. Warn user when initiating the widget without "set key" present.

The logs in console are, and the widget does not initiate, but the user is not notified:

WidgetBlocks.js:217 Uncaught TypeError: Cannot read property 'connections' of undefined
    at TemperamentBlock.flow (WidgetBlocks.js:217)
    at Logo._runFromBlockNow (logo.js:1875)
    at logo.js:1544

Otherwise, we might say that if only a pitch block is given, we assume the major key for the specified pitch. (I am unsure why we even need both blocks. We may only need "set key".)

  1. Right now, we show the numbers for the degrees of the chromatic scale for a given temperament system. Upon initiation, we should also have an outer circle with regular solfege pitch names. We need only display the pitches for the specified key. Having this would orient the user, as the numbers by themselves are abstract. For a custom temperament, we can keep the (equal temperament) placements of the scalar pitches. This will visually orient the user to compare their new temperament to their specified key in equal temperament.

  2. When using "equal" and "ratio" tools, and then previewing the results via "preview", when the user goes back via "back" their work is lost. They need to type all their values in again.

  3. We should probably have some defaults for "equal" and "ratio" tools in order to spark the imagination. I usually choose "5" for divisions for "equal" (no other changes) and "3:2" with recursion of "11" for ratio. I don't know what a good default for our octave tool could be, maybe "3:1". This should help get someone started.

  4. The octave tool does not seem to playback the correct pitches. Needs investigation.

  5. The arbitrary tool could benefit from some a design review. It may be hard for a user to know where on the circle to click in order to generate a new pitch.

@pikurasa pikurasa added Issue-Enhancement Component-Temperament related to temperament Component-Widget relating to a widget labels Jun 12, 2020
@sksum sksum added the WF6-Needs testing Please test label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Temperament related to temperament Component-Widget relating to a widget Issue-Enhancement WF6-Needs testing Please test
Projects
None yet
Development

No branches or pull requests

3 participants