Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade font-awesome from 4.7 #4143

Open
jcoyne opened this issue Mar 15, 2024 · 0 comments
Open

Upgrade font-awesome from 4.7 #4143

jcoyne opened this issue Mar 15, 2024 · 0 comments

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Mar 15, 2024

We're currently using font-awesome 4.7 which was released over 7 years ago: https://www.npmjs.com/package/font-awesome The current version is 6.5 (https://docs.fontawesome.com/web/use-with/scss/)

4.7 uses the / operator which is currently deprecated in sass:

12:50:39 css.1  | Recommendation: math.div(30em, 14) or calc(30em / 14)
12:50:39 css.1  |
12:50:39 css.1  | More info and automated migrator: https://sass-lang.com/d/slash-div
12:50:39 css.1  |
12:50:39 css.1  |    ╷
12:50:39 css.1  | 12 │ $fa-li-width:         (30em / 14) !default;
12:50:39 css.1  |    │                        ^^^^^^^^^
12:50:39 css.1  |    ╵
12:50:39 css.1  |     node_modules/font-awesome/scss/_variables.scss 12:24  @import
12:50:39 css.1  |     font-awesome/scss/font-awesome.scss 6:9               @import
12:50:39 css.1  |     app/assets/stylesheets/application.sass.scss 11:9     root stylesheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant