diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 467ba7a9..066f81a9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,13 +1,13 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-01-18 22:57:39 UTC using RuboCop version 0.93.1. +# on 2023-11-03 20:55:41 UTC using RuboCop version 1.57.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineMethodCallBraceLayout: @@ -16,21 +16,21 @@ Layout/MultilineMethodCallBraceLayout: - 'spec/routing/media_routing_spec.rb' # Offense count: 7 -# Configuration parameters: IgnoredMethods. +# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 22 # Offense count: 2 -# Configuration parameters: IgnoredMethods. +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 10 -# Offense count: 12 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. +# Offense count: 13 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 25 -# Offense count: 34 +# Offense count: 35 RSpec/AnyInstance: Exclude: - 'spec/controllers/media_controller_spec.rb' @@ -44,7 +44,7 @@ RSpec/AnyInstance: - 'spec/requests/media_auth_request_spec.rb' # Offense count: 89 -# Configuration parameters: Prefixes. +# Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without RSpec/ContextWording: Exclude: @@ -62,23 +62,8 @@ RSpec/ContextWording: - 'spec/services/iiif_metadata_service_spec.rb' - 'spec/services/media_authentication_json_spec.rb' -# Offense count: 10 -# Configuration parameters: IgnoredMetadata. -RSpec/DescribeClass: - Exclude: - - 'spec/features/iiif_spec.rb' - - 'spec/features/status_spec.rb' - - 'spec/requests/iiif_spec.rb' - - 'spec/requests/remote_iiif_image_delivery_spec.rb' - - 'spec/routing/file_routing_spec.rb' - - 'spec/routing/iiif_routing_spec.rb' - - 'spec/routing/legacy_image_api_spec.rb' - - 'spec/routing/media_routing_spec.rb' - - 'spec/routing/webauth_routing_spec.rb' - - 'spec/views/webauth/logout.html.erb_spec.rb' - # Offense count: 27 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: SkipBlocks, EnforcedStyle. # SupportedStyles: described_class, explicit RSpec/DescribedClass: @@ -88,7 +73,7 @@ RSpec/DescribedClass: - 'spec/models/user_spec.rb' # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterExampleGroup: Exclude: - 'spec/abilities/ability_spec.rb' @@ -96,7 +81,7 @@ RSpec/EmptyLineAfterExampleGroup: - 'spec/requests/file_auth_request_spec.rb' # Offense count: 37 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterFinalLet: Exclude: - 'spec/abilities/ability_spec.rb' @@ -110,7 +95,8 @@ RSpec/EmptyLineAfterFinalLet: - 'spec/services/media_authentication_json_spec.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowConsecutiveOneLiners. RSpec/EmptyLineAfterHook: Exclude: - 'spec/controllers/application_controller_spec.rb' @@ -118,7 +104,7 @@ RSpec/EmptyLineAfterHook: - 'spec/requests/iiif_spec.rb' # Offense count: 12 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterSubject: Exclude: - 'spec/abilities/ability_spec.rb' @@ -129,29 +115,24 @@ RSpec/EmptyLineAfterSubject: - 'spec/models/stacks_image_spec.rb' - 'spec/services/iiif_metadata_service_spec.rb' -# Offense count: 22 -# Configuration parameters: Max. +# Offense count: 20 +# Configuration parameters: CountAsOne. RSpec/ExampleLength: - Exclude: - - 'spec/controllers/iiif_controller_spec.rb' - - 'spec/controllers/legacy_image_service_controller_spec.rb' - - 'spec/controllers/object_controller_spec.rb' - - 'spec/features/iiif_spec.rb' - - 'spec/models/purl_spec.rb' - - 'spec/models/stacks_media_token_spec.rb' - - 'spec/requests/media_auth_request_spec.rb' - - 'spec/services/iiif_info_service_spec.rb' + Max: 24 -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: CustomTransform, IgnoredWords. +# Offense count: 15 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples. +# DisallowedExamples: works RSpec/ExampleWording: Exclude: + - 'spec/controllers/legacy_image_service_controller_spec.rb' - 'spec/controllers/media_controller_spec.rb' - 'spec/models/stacks_media_token_spec.rb' + - 'spec/requests/iiif_auth_request_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, each, example RSpec/HookArgument: @@ -160,7 +141,7 @@ RSpec/HookArgument: - 'spec/requests/iiif_auth_request_spec.rb' # Offense count: 8 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/LeadingSubject: Exclude: - 'spec/controllers/file_controller_spec.rb' @@ -178,12 +159,13 @@ RSpec/MessageSpies: - 'spec/controllers/file_controller_spec.rb' - 'spec/controllers/media_controller_spec.rb' -# Offense count: 66 +# Offense count: 67 RSpec/MultipleExpectations: Max: 12 # Offense count: 81 -# Configuration parameters: IgnoreSharedExamples. +# Configuration parameters: EnforcedStyle, IgnoreSharedExamples. +# SupportedStyles: always, named_only RSpec/NamedSubject: Exclude: - 'spec/controllers/application_controller_spec.rb' @@ -201,7 +183,8 @@ RSpec/NamedSubject: - 'spec/services/iiif_metadata_service_spec.rb' - 'spec/services/media_authentication_json_spec.rb' -# Offense count: 62 +# Offense count: 66 +# Configuration parameters: AllowedGroups. RSpec/NestedGroups: Max: 6 @@ -211,6 +194,12 @@ RSpec/RepeatedDescription: - 'spec/routing/file_routing_spec.rb' - 'spec/routing/legacy_image_api_spec.rb' +# Offense count: 5 +RSpec/StubbedMock: + Exclude: + - 'spec/controllers/file_controller_spec.rb' + - 'spec/controllers/media_controller_spec.rb' + # Offense count: 1 RSpec/SubjectStub: Exclude: @@ -235,17 +224,8 @@ Rails/FilePath: - 'app/controllers/application_controller.rb' - 'spec/controllers/file_controller_spec.rb' -# Offense count: 12 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: numeric, symbolic -Rails/HttpStatus: - Exclude: - - 'spec/requests/file_auth_request_spec.rb' - - 'spec/requests/iiif_auth_request_spec.rb' - # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: separated, grouped Style/AccessorGrouping: @@ -253,13 +233,13 @@ Style/AccessorGrouping: - 'app/models/stacks_image.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/EmptyCaseCondition: Exclude: - 'app/controllers/legacy_image_service_controller.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: braces, no_braces Style/HashAsLastArrayItem: @@ -267,7 +247,7 @@ Style/HashAsLastArrayItem: - 'app/controllers/object_controller.rb' # Offense count: 18 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: Exclude: @@ -278,7 +258,8 @@ Style/PercentLiteralDelimiters: - 'spec/requests/media_auth_request_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Mode. Style/StringConcatenation: Exclude: - 'app/controllers/iiif_controller.rb' @@ -286,8 +267,16 @@ Style/StringConcatenation: - 'spec/models/stacks_media_token_spec.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MinSize. # SupportedStyles: percent, brackets Style/SymbolArray: EnforcedStyle: brackets + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. +# AllowedMethods: define_method +Style/SymbolProc: + Exclude: + - 'app/controllers/webauth_controller.rb'