Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): stories fail to render #504

Merged
merged 1 commit into from
Oct 29, 2019
Merged

fix(docs): stories fail to render #504

merged 1 commit into from
Oct 29, 2019

Conversation

connor-baer
Copy link
Member

Purpose

Normal stories are currently broken on circuit.sumup.com. They show the following error: fn.apply is not a function.

Approach and changes

  • require withTest decorator correctly

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Oct 29, 2019
robinmetral
robinmetral approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
It would be nice to have our CI build a deploy preview at some point, to avoid having to release to see changes 🙂

@connor-baer
Copy link
Member Author

connor-baer commented Oct 29, 2019 •
edited
Loading

@robinmetral I'd love to switch to Zeit Now for hosting (they offer this feature). Now that we're part of the OSS org, this shouldn't be a problem.

@felixjung You're using Now for the OSS website, right? Does SumUp have a Zeit account or is it using your personal one? Where is the code for the website located?

@connor-baer connor-baer merged commit c203b43 into canary Oct 29, 2019
@connor-baer connor-baer deleted the bugfix/storybook-with-tests branch October 29, 2019 17:30
@connor-baer
Copy link
Member Author

🎉 This PR is included in version 1.4.1-canary.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@connor-baer
Copy link
Member Author

🎉 This PR is included in version 2.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@connor-baer
Copy link
Member Author

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsodelgado afonsodelgado afonsodelgado approved these changes

@robinmetral robinmetral robinmetral approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working as it should
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connor-baer @afonsodelgado @robinmetral