feat(components): expose sidebar context #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expose sidebar context that allows it to be used with the useContext hook. This allows the side bar context to be used in a simpler pattern that does not require the render props method of usage.
Codecov Report
@@ Coverage Diff @@
## canary #512 +/- ##
=======================================
Coverage 79.65% 79.65%
=======================================
Files 172 172
Lines 2477 2477
Branches 445 445
=======================================
Hits 1973 1973
Misses 388 388
Partials 116 116
|
robinmetral
reviewed
Nov 27, 2019
fernandofleury
approved these changes
Nov 27, 2019
|
🎉 This PR is included in version 1.4.1-canary.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
connor-baer
pushed a commit
that referenced
this pull request
Dec 11, 2019
expose sidebar context that allows it to be used with the useContext hook. This allows the side bar context to be used in a simpler pattern that does not require the render props method of usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Expose sidebar context that allows it to be used with the useContext hook.
Currently the sideBar context is accessed using the render props method like so.
This method of accessing was necessary in the past, however with the availability of the useContext hook it makes things a lot more simpler and elegant.
Approach and changes
With this PR, we also enable consuming the context with the useContext hook, however we still support the older render props access method so we don't break things.
Definition of done