feat(components): extract icons to separate package #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#531) * fix(components): add class to html when Modal is open Co-authored-by: Lari Maza <larissa.maza@sumup.com> * fix(components): move global styles to ModalProvider Co-authored-by: Lari Maza <larissa.maza@sumup.com> Co-authored-by: Lari Maza <larissa.maza@gmail.com>
* fix: adds Select margin top when label above * fix: Adjust export naming for the base Select case
* chore(configs): fix deployment to GH Pages * chore(configs): resolve lint issues in Travis config * chore(configs): do not run tests before deploy * chore(configs): opt into v2 deployments * chore(configs): deploy from the master branch only * Revert "chore(configs): do not run tests before deploy" This reverts commit 4d11c26.
* docs(docs): fix story hierarchy separators in links * docs(components): prevent awkward wrapping on the homepage
#549) * feat(components): add input value change callback to AutocompleteInput This enables dynamic fetching and updating of the suggestion items. * feat(components): add support for async filtering to the AutoCompleteInput * docs(components): rename items to options * test(components): update snapshots * refactor(components): use new prop name in AutoCompleteTags * feat(components): improve styles of AutocompleteInput * style(components): rename style object
* fix: don't pass invalid props to Link * fix: added unit test * fix: implemented shouldForwardProp
* Remove default clear icon from SearchInput component * Update snapshot tests * Render clear icon based on onClear handler; Add unit tests * Fix story * Fix snapshot test Co-authored-by: Mariela Kasovska <mariela.kasovska@sumup.com>
This should make it easier to find code samples.
…ion (#558) * fix(components): make AutocompleteInput compatible with new clear option * test(components): update storyshots * fix(components): improve prop type
* feat(components): increase tap target size on input prefix and suffix By switching from margin to padding for the spacing, the prefix and suffix elements get a much larger tap target size: 16px to 40px. This is especially important on touchscreen devices, but also improves usability for mouse users. * feat(components): improve accessibility of the SearchInput clear button * fix(components): deprecate showClear in favor of onClear prop This brings the AutocompleteInput API in line with the SearchInput API. It also fixes the functionality of the clear button on the AutocompleteInput.
* feat(components): pass initial value to AutocompleteInput * test(components): update storyshots
* Refactor AutoCompleteTags * Update snapshot tests * Make AutoCompleteTags class * Update snapshots * Update src/components/AutoCompleteTags/AutoCompleteTags.spec.js Co-Authored-By: Connor Bär <connor-baer@users.noreply.github.com> * Fix test Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
This script errors most of the time. It works on the alpha branch which uses GitHub Actions.
* Update InfoIcon component
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/4vd23gjbb |
8 tasks
Codecov Report
@@ Coverage Diff @@
## alpha #571 +/- ##
==========================================
+ Coverage 92.51% 93.04% +0.53%
==========================================
Files 223 150 -73
Lines 3021 2417 -604
Branches 710 685 -25
==========================================
- Hits 2795 2249 -546
+ Misses 191 137 -54
+ Partials 35 31 -4
|
* Toggle component - ability to be right aligned * Fixed typo * ESLint fix - max-len * Storyshots snapshot updated * PR comments changes * Snapshot update * Space added between text and Switch * Snapshot update * Reversed Toggle only shown on mobile
* Replace right and left icon with render props * Update docs and storyshots
BREAKING CHANGE: The CardSchemes and PaymentMethodIcon components have been removed. Use [@sumup/icons](https://github.com/sumup-oss/icons) instead. feature/icons
This component wasn't publicly exposed or used internally. Just dead code. feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
feature/icons
connor-baer
force-pushed
the
feature/icons
branch
from
84db577
to
a158972
Compare
|
🎉 This PR is included in version 2.0.0-alpha.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #528.
Approach and changes
Extract all icons to a new package @sumup/icons
fillandstrokeattributes set tocurrentColor, so their color can be changed by setting the CSScolorReplace and remove all SVGs from Circuit UI
Document the new icons
Definition of done