feat(theme): extract design tokens to separate package #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/ieheikgex |
Codecov Report
@@ Coverage Diff @@
## alpha #572 +/- ##
==========================================
- Coverage 93.51% 93.41% -0.11%
==========================================
Files 150 150
Lines 2436 2429 -7
Branches 692 688 -4
==========================================
- Hits 2278 2269 -9
- Misses 130 132 +2
Partials 28 28
|
connor-baer
requested review from
fernandofleury,
afonsodelgado and
robinmetral
robinmetral
approved these changes
Apr 28, 2020
The new package can be found at https://github.com/sumup-oss/design-tokens. BREAKING CHANGE: The theme has been moved to [@sumup/design-tokens](https://github.com/sumup-oss/design-tokens) which is marked as a peer-dependency. The `iconSizes.byte` theme value has been removed. The `grid.afterTera` theme value has been renamed to `theme.tera`. ISSUES CLOSED: #511 feature/design-tokens
feature/design-tokens
feature/design-tokens
connor-baer
force-pushed
the
feature/design-tokens
branch
from
901e44e
to
098a90d
Compare
|
🎉 This PR is included in version 2.0.0-alpha.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511.
Approach and changes
circuit/standardtolightDefinition of done