Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add Anchor component #583

Merged
merged 3 commits into from
May 4, 2020
Merged

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented May 3, 2020

Relates to #582.

Purpose

The Anchor component should be used for textual links or buttons, usually inline in long-form text. It is the successor of the plain Button variant.

Approach and changes

👀 Live preview

Default

Screenshot 2020-05-03 12 09 46

Hovered

Screenshot 2020-05-03 12 10 30

Focused

Screenshot 2020-05-03 12 09 52

Visited

Screenshot 2020-05-03 12 10 15

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added feature A new feature or enhancement 🎨 design Requires input from designers labels May 3, 2020
@connor-baer connor-baer added this to the v2.0 milestone May 3, 2020
@vercel
Copy link

vercel bot commented May 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/5noyi0ln4
✅ Preview: https://circuit-ui-git-feature-component-anchor.sumup-oss.now.sh

@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #583 into alpha will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #583      +/-   ##
==========================================
+ Coverage   93.33%   93.50%   +0.16%     
==========================================
  Files         150      153       +3     
  Lines        2402     2448      +46     
  Branches      680      685       +5     
==========================================
+ Hits         2242     2289      +47     
  Misses        132      132              
+ Partials       28       27       -1     
Impacted Files Coverage Δ
src/components/Anchor/Anchor.tsx 100.00% <100.00%> (ø)
src/components/Blockquote/Blockquote.js 100.00% <100.00%> (ø)
...nents/Button/components/PlainButton/PlainButton.js 100.00% <100.00%> (ø)
src/components/Text/Text.tsx 100.00% <100.00%> (ø)
src/components/Toggle/Toggle.js 100.00% <100.00%> (ø)
src/styles/style-helpers.ts 100.00% <100.00%> (ø)
src/styles/styled.ts 100.00% <100.00%> (ø)
src/util/test-utils.tsx 100.00% <100.00%> (ø)
...s/Button/components/RegularButton/RegularButton.js 94.28% <0.00%> (-2.86%) ⬇️
... and 4 more

Copy link
Contributor

@hleote hleote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌 💯 👍

Copy link
Contributor

@jmaslate jmaslate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@connor-baer connor-baer changed the base branch from feature/typescript-text to alpha May 4, 2020 12:30
feature/button-enums

feature/button-enums

feature/button-enums
feature/component-anchor

feature/component-anchor
@connor-baer connor-baer merged commit eeec0de into alpha May 4, 2020
@connor-baer connor-baer deleted the feature/component-anchor branch May 4, 2020 12:33
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2020

🎉 This PR is included in version 2.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2020

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Requires input from designers feature A new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants