Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add prop codemods #600

Merged
merged 7 commits into from
Jun 4, 2020
Merged

feat(cli): add prop codemods #600

merged 7 commits into from
Jun 4, 2020

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jun 1, 2020

Follow-up to #596.

Purpose

Circuit UI v2 comes with a lot of breaking changes — most small and component-specific, but together they add up to a lot of manual work for the users. We can automate these changes with codemods, small scripts that modify the source code automatically.

This PR focuses on prop related codemods. Other codemods will come in follow-up PRs.

Approach and changes

  • add codemod to change List boolean props to enum prop
  • add codemod to rename onChange props for RadioButton and Switch
  • add codemod to rename as prop for Heading, SubHeading, Text, and Input
  • add codemod to rename onChange and checked props for Selector
  • add codemod to remove exit animations from LoadingButton
  • add codemod to rename ref prop for Input

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the feature A new feature or enhancement label Jun 1, 2020
@connor-baer connor-baer added this to the v2.0 milestone Jun 1, 2020
@vercel
Copy link

vercel bot commented Jun 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/q2bucdfr2
✅ Preview: https://circuit-ui-git-feature-codemods.sumup-oss.now.sh

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #600 into alpha will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            alpha     #600   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files         136      136           
  Lines        2198     2198           
  Branches      631      631           
=======================================
  Hits         2072     2072           
  Misses        103      103           
  Partials       23       23           

Base automatically changed from feature/codemod-button to alpha June 4, 2020 09:00
@connor-baer connor-baer changed the title feat(cli): add more codemods feat(cli): add prop codemods Jun 4, 2020
@connor-baer connor-baer marked this pull request as ready for review June 4, 2020 10:01
@connor-baer connor-baer merged commit f9cbb24 into alpha Jun 4, 2020
@connor-baer connor-baer deleted the feature/codemods branch June 4, 2020 14:10
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2020

🎉 This PR is included in version 2.0.0-alpha.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2020

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants