Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): update design of ProgressBar #602

Merged
merged 5 commits into from
Jun 3, 2020

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jun 2, 2020

Purpose

The ProgressBar is receiving a fresh coat of paint and some additional configuration options to cover more use cases.

Approach and changes

  • migrate ProgressBar to TypeScript
  • add secondary variant in dark gray
  • add byte and remove tera size
  • add alternative progress bar "kind" for time-based tasks (as opposed to step-based)
  • replace the progress component in the Carousel

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Co-authored-by: amelako <amela.kodzic@sumup.com>, Fernando Fleury <fernando.fleury@sumup.com>

feature/typescript-progressbar
Co-authored-by: amelako <amela.kodzic@sumup.com>, Fernando Fleury <fernando.fleury@sumup.com>

feature/typescript-progressbar
feature/typescript-progressbar
@connor-baer connor-baer added feature A new feature or enhancement 🎨 design Requires input from designers labels Jun 2, 2020
@connor-baer connor-baer added this to the v2.0 milestone Jun 2, 2020
@vercel
Copy link

vercel bot commented Jun 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/ixha0dfxm
✅ Preview: https://circuit-ui-git-feature-typescript-progressbar.sumup-oss.now.sh

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #602 into alpha will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #602      +/-   ##
==========================================
+ Coverage   94.22%   94.24%   +0.02%     
==========================================
  Files         137      136       -1     
  Lines        2183     2191       +8     
  Branches      622      631       +9     
==========================================
+ Hits         2057     2065       +8     
  Misses        103      103              
  Partials       23       23              
Impacted Files Coverage Δ
src/components/Carousel/Carousel.js 100.00% <100.00%> (ø)
src/components/ProgressBar/ProgressBar.tsx 100.00% <100.00%> (ø)

feature/typescript-progressbar
@connor-baer connor-baer merged commit 6625699 into alpha Jun 3, 2020
@connor-baer connor-baer deleted the feature/typescript-progressbar branch June 3, 2020 15:07
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2020

🎉 This PR is included in version 2.0.0-alpha.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2020

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design Requires input from designers feature A new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants