Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): tweak components #606

Merged
merged 4 commits into from
Jun 4, 2020
Merged

feat(components): tweak components #606

merged 4 commits into from
Jun 4, 2020

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jun 4, 2020

Purpose

The changes are a collection of small tweaks that I felt were too small to put into seperate PRs.

Approach and changes

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added 🐞 bug Something isn't working as it should feature A new feature or enhancement labels Jun 4, 2020
@connor-baer connor-baer added this to the v2.0 milestone Jun 4, 2020
@vercel
Copy link

vercel bot commented Jun 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/ms54ub81p
✅ Preview: https://circuit-ui-git-feature-polish-v2.sumup-oss.now.sh

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #606 into alpha will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #606      +/-   ##
==========================================
+ Coverage   94.16%   94.17%   +0.01%     
==========================================
  Files         135      135              
  Lines        2227     2231       +4     
  Branches      635      638       +3     
==========================================
+ Hits         2097     2101       +4     
  Misses        106      106              
  Partials       24       24              
Impacted Files Coverage Δ
...rc/components/Notification/components/Icon/Icon.js 100.00% <ø> (ø)
src/components/Anchor/Anchor.tsx 100.00% <100.00%> (ø)
src/components/Badge/Badge.js 100.00% <100.00%> (ø)
src/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/components/Card/Card.js 100.00% <100.00%> (ø)
src/components/Col/Col.js 100.00% <100.00%> (ø)
src/components/Toggle/Toggle.js 100.00% <100.00%> (ø)

@connor-baer connor-baer merged commit f14269d into alpha Jun 4, 2020
@connor-baer connor-baer deleted the feature/polish-v2 branch June 4, 2020 20:08
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2020

🎉 This PR is included in version 2.0.0-alpha.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2020

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should feature A new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants