feat(components): add subtle animations #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/button-transitions feature/button-transitions
feature/button-transitions
connor-baer
added
feature
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/6mv4am2m8 |
Codecov Report
@@ Coverage Diff @@
## beta #623 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 133 133
Lines 2155 2155
Branches 596 596
=======================================
Hits 2022 2022
Misses 111 111
Partials 22 22
|
feature/button-transitions feature/button-transitions
connor-baer
force-pushed
the
feature/button-transitions
branch
from
746caf4
to
f855a81
Compare
fernandofleury
approved these changes
Jun 25, 2020
|
🎉 This PR is included in version 2.0.0-beta.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Animations in Circuit UI have been very inconsistent so far — some components have state transitions (Toggle, Checkbox), others don’t (Button, Tag). When we started Circuit UI 2 years ago, we planned to add transitions later, but that never happened. In v2, I’d like to add subtle transitions to all interactive components (they can be polished later).
✅ Approved by Giao-Chung from the design team.
Approach and changes
Definition of done