feat(components): migrate Notification components to TypeScript #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The **InlineMessage** component's `type` prop has been renamed to `variant` (🤖 _inline-message-variant-enum_) feature/typescript-messages
feature/typescript-messages
BREAKING CHANGE: The NotificationIcon and NotificationButton components have been removed. Use the Notification component's icon and children props instead. feature/typescript-messages
feature/typescript-messages
feature/typescript-messages
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/k27ltdozp |
Codecov Report
@@ Coverage Diff @@
## beta #637 +/- ##
==========================================
- Coverage 93.71% 93.69% -0.03%
==========================================
Files 133 131 -2
Lines 2213 2219 +6
Branches 612 617 +5
==========================================
+ Hits 2074 2079 +5
- Misses 117 118 +1
Partials 22 22
|
fernandofleury
approved these changes
Jul 16, 2020
|
🎉 This PR is included in version 2.0.0-beta.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #516.
Purpose
The current Notification component composition is quite brittle because it depends on the proper positioning of each component to work. It also makes it impossible to change the layout and composition of the notifications in the future. This is solved by replacing the subcomponents (NotificationIcon and NotificationButton) with props on the main Notification component.
Approach and changes
BREAKING CHANGE:
The NotificationIcon and NotificationButton components have been removed. Use the Notification component's
iconandchildrenprops instead.Definition of done