Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): fix cross browser inconsistencies #639

Merged
merged 9 commits into from
Jul 16, 2020

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jul 15, 2020

Addresses TL-230, TL-231, TL-190, and TL-187.

Purpose

@jess-acacio found a number of issues when testing all components across all major browsers.

Approach and changes

  • show Input outline on iOS
  • mark Checkbox as valid when checked
  • position prev/next month buttons in Calendar
  • make Card height dynamic in Storybook

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Jul 15, 2020
@connor-baer connor-baer added this to the v2.0 milestone Jul 15, 2020
@vercel
Copy link

vercel bot commented Jul 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/nznncckzh
✅ Preview: https://circuit-ui-git-bugfix-cross-browser-testing.sumup-oss.vercel.app

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #639 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #639   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files         131      131           
  Lines        2236     2236           
  Branches      624      624           
=======================================
  Hits         2096     2096           
  Misses        118      118           
  Partials       22       22           
Impacted Files Coverage Δ
...mponents/CalendarWrapper/CalendarImportedStyles.js 100.00% <ø> (ø)
...ndar/components/CalendarWrapper/CalendarWrapper.js 100.00% <ø> (ø)
src/components/Input/Input.tsx 98.24% <ø> (ø)

bugfix/cross-browser-testing
bugfix/cross-browser-testing
@vercel vercel bot temporarily deployed to Preview July 16, 2020 13:26 Inactive
bugfix/cross-browser-testing
@connor-baer connor-baer merged commit d982098 into beta Jul 16, 2020
@connor-baer connor-baer deleted the bugfix/cross-browser-testing branch July 16, 2020 15:15
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-beta.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants