Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add codemods for theme changes #641

Merged
merged 5 commits into from
Jul 17, 2020

Conversation

connor-baer
Copy link
Member

Purpose

These codemods cover the breaking changes related to the theme.

Approach and changes

  • The themes have been moved to @sumup/design-tokens. Import them from there instead (🤖 theme-to-design-tokens)
  • The iconSizes.byte theme value has been removed. Use iconSizes.kilo instead (🤖 theme-icon-sizes)
  • The grid.afterTera theme value has been renamed to grid.tera (🤖 theme-grid-tera)

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

feature/migration-theme

feature/migration-theme
@connor-baer connor-baer added the feature A new feature or enhancement label Jul 17, 2020
@connor-baer connor-baer added this to the v2.0 milestone Jul 17, 2020
@vercel
Copy link

vercel bot commented Jul 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/gylmdwv6j
✅ Preview: https://circuit-ui-git-feature-migration-theme.sumup-oss.vercel.app

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #641 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #641   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files         131      131           
  Lines        2236     2236           
  Branches      624      624           
=======================================
  Hits         2096     2096           
  Misses        118      118           
  Partials       22       22           

feature/migration-theme
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-beta.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants