From 437976b3fab10421e71b0d09b052455a6748055b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Connor=20B=C3=A4r?= Date: Wed, 6 Sep 2023 11:39:31 +0200 Subject: [PATCH 1/2] Widen SelectorGroup's icon prop type --- .changeset/slimy-weeks-rescue.md | 5 +++++ packages/circuit-ui/components/Selector/Selector.tsx | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/slimy-weeks-rescue.md diff --git a/.changeset/slimy-weeks-rescue.md b/.changeset/slimy-weeks-rescue.md new file mode 100644 index 0000000000..4f576be482 --- /dev/null +++ b/.changeset/slimy-weeks-rescue.md @@ -0,0 +1,5 @@ +--- +'@sumup/circuit-ui': patch +--- + +Widened the type for the SelectorGroup's new `icon` prop. diff --git a/packages/circuit-ui/components/Selector/Selector.tsx b/packages/circuit-ui/components/Selector/Selector.tsx index 3dc7f9c9ee..0b39bcad79 100644 --- a/packages/circuit-ui/components/Selector/Selector.tsx +++ b/packages/circuit-ui/components/Selector/Selector.tsx @@ -14,6 +14,7 @@ */ import { + ComponentType, Fragment, InputHTMLAttributes, createContext, @@ -21,7 +22,6 @@ import { useContext, useId, } from 'react'; -import type { IconComponentType } from '@sumup/icons'; import { AccessibilityError, @@ -49,7 +49,7 @@ export interface SelectorProps /** * Display an icon in addition to the text to help to identify the option. */ - icon?: IconComponentType; + icon?: ComponentType<{ 'className': string; 'aria-hidden': 'true' }>; /** * Value string for input. */ From fc7f12d8dce717dbe7a065212dfc018bd2222bf6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Connor=20B=C3=A4r?= Date: Wed, 6 Sep 2023 11:52:55 +0200 Subject: [PATCH 2/2] Pin Node 20 version https://github.com/babel/babel/issues/15927 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1332a7670d..412d96390e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [18, 20] + node: [18, 20.5] steps: - name: Checkout repository uses: actions/checkout@v3