Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to get the missing variable path from error #546

Merged
merged 6 commits into from
Nov 21, 2022

Conversation

linw1995
Copy link
Contributor

This allows developers to get the missing variable path from the error and produce a customized hint message to the frontend users.

src/error.rs Outdated Show resolved Hide resolved
Copy link
Owner

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please check format and lint errors. Thanks!

src/error.rs Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 21, 2022

Coverage Status

Coverage decreased (-0.2%) to 79.988% when pulling 832679d on linw1995:master into 80687a7 on sunng87:master.

@sunng87
Copy link
Owner

sunng87 commented Nov 21, 2022

LGTM. @linw1995 Thanks for your patient!

@sunng87 sunng87 merged commit b70f773 into sunng87:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants