Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render arrays without trailing commas #588

Conversation

aromeronavia
Copy link
Contributor

Problem

Arrays are being rendered with trailing commas
Related to #587

Solution

Verify when rendering an array that last element being rendered does not include a comma and space

Added tests ✅

@coveralls
Copy link

Coverage Status

coverage: 80.81% (+0.09%) from 80.717% when pulling 7d78793 on aromeronavia:alberto/render-arrays-without-trailing-commas into 23ca8d7 on sunng87:master.

@sunng87
Copy link
Owner

sunng87 commented Jun 14, 2023

Nice! Thank you very much!

@sunng87 sunng87 merged commit 5dc55a6 into sunng87:master Jun 14, 2023
@aromeronavia aromeronavia deleted the alberto/render-arrays-without-trailing-commas branch June 16, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants