Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crate feature flags to use rustls-tls instead of native-tls in reqwest crate #11

Closed
jonatino opened this issue Dec 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jonatino
Copy link

jonatino commented Dec 20, 2024

Feature request

Is your feature request related to a problem? Please describe.

Right now you use the reqwest crate with default features. By default it uses native-tls which is a bit of a pain to build for android since you need your own openssl dependency. Could you add features to this crate which allow us to use a rustls implementation for tls?

Describe the solution you'd like

Eg (note the default-features=false since it's required to avoid the native-tls dependency in reqwest):

reqwest = { version = "0.12.9", default-features = false, features = ["rustls-tls"] }
@jonatino jonatino added the enhancement New feature or request label Dec 20, 2024
@Proziam
Copy link
Collaborator

Proziam commented Dec 25, 2024

Apologies for the delayed response, the holiday season is upon us.

I'll look into it this week 👍

@Proziam
Copy link
Collaborator

Proziam commented Dec 27, 2024

Version 10.0.6 now has the use-rustls feature. I also discovered a discussion on Reqwest about using rustls as the default which I will start tracking.

Let me know if this works for you, and thanks for taking the time to open the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants