Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 shallow routing triggering scroll to top #68

Open
kuuak opened this issue Nov 12, 2024 · 0 comments
Open

fix: 🐛 shallow routing triggering scroll to top #68

kuuak opened this issue Nov 12, 2024 · 0 comments
Assignees
@charl0tee @geck1942
Labels
enhancement New feature or request

Comments

@kuuak
Copy link
Contributor

kuuak commented Nov 12, 2024

It is not perfect as we use shallow to avoid the scroll to top, however the routeChangeComplete event doesn't give the scroll option.

We could for now handle it like this be maybe in the future have a context to indicate that the current url change does not want a scroll to top

https://github.com/superhuit-agency/usasa.org/commit/d2fd47254939f36cba89e1faeb96cbcd1429452c

We should maybe as well fix it on FWT. cc @geck1942
@kuuak kuuak added the enhancement New feature or request label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charl0tee charl0tee

@geck1942 geck1942

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@charl0tee @kuuak @geck1942