Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signout does not share cookies between OkHttp3 and HttpURLConnection #33

Open
nkshah2 opened this issue Aug 10, 2022 · 0 comments
Open

Comments

@nkshah2
Copy link
Contributor

nkshah2 commented Aug 10, 2022

Cookies between OkHttp3 clients and HttpURLConnection requests are not guaranteed to be shared. As a result when using sessions with OkHttp3/Retrofit SuperTokens.signOut does not actually clear the session.

This is because the signout function internally uses httpurlconnection.

To solve this problem, it is best that the sign out API is called directly without using a helper function. The SuperTokens.signOut function should be marked as deprecated

@nkshah2 nkshah2 self-assigned this Aug 10, 2022
@dreuff dreuff mentioned this issue Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant